This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH]: Fix compile time warning building ARM port of GAS
Hi Zack,
OK, in which case we need to fix this non-T macros. What do you think
of the attached patch ?
Looks good to me, except I would prefer the use of 0 rather than NULL,
for consistency with the rest of the file.
OK - I have checked the patch in with the ChangeLog entry below. I
reverted the definition of do_0 to 0 as requested although personally I
think that this is wrong - it is being used to initialise a pointer
field not an integer field - but I am not so anal as to insist on it.
(Although I did once work with a compiler where 0 was a valid address
and NULL was defined to a non-zero value. That was fun!)
Ah. I'm using 3.3 (Debian's default). Now I think about it, this
warning was only added in 3.4.
We probably ought to be building and checking with a 4.0 compiler on a
regular basis as well... Oh well, another thing to add to the list of
jobs to do.
Cheers
Nick
gas/ChangeLog
2005-06-04 Nick Clifton <nickc@redhat.com>
* config/tc-arm.c (CE, C3, CM, UE, UF): Redefine without reference
to their Thumb-enabled equivalents.