This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA:] ar test failure fix

From: Alan Modra <amodra at bigpond dot net dot au>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>,binutils at sourceware dot org
Date: Wed, 8 Jun 2005 13:24:44 +0930
Subject: Re: [RFA:] ar test failure fix
References: <200506080301.j5831vK0025112@ignucius.se.axis.com> <42A662D6.4080204@codesourcery.com>

On Tue, Jun 07, 2005 at 08:15:34PM -0700, Mark Mitchell wrote:
> Perhaps, even, the caller is buggy?

Not really.  The sequence of events was

- bfd_error cleared

- lots of intervening code

- bfd_bread returning zero bytes, then a test on bfd_error to see
  whether the short read was due to a file error of some sort.

You happened to change some of that intervening code in a way that set
bfd_error when there was no error.  ar.c could be made more robust by
reducing the amount of intervening code, but I think it's OK as is.
I also think that it's no business of bfd_bread to clear bfd_error on
success.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Follow-Ups:
- Re: [RFA:] ar test failure fix
  - From: Mark Mitchell

References:
- Re: [RFA:] ar test failure fix
  - From: Hans-Peter Nilsson
- Re: [RFA:] ar test failure fix
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]