This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA:] ar test failure fix

From: Mark Mitchell <mark at codesourcery dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>, binutils at sourceware dot org
Date: Tue, 07 Jun 2005 21:10:53 -0700
Subject: Re: [RFA:] ar test failure fix
References: <200506080301.j5831vK0025112@ignucius.se.axis.com> <42A662D6.4080204@codesourcery.com> <20050608035444.GV2677@bubble.grove.modra.org>

Alan Modra wrote:

On Tue, Jun 07, 2005 at 08:15:34PM -0700, Mark Mitchell wrote:

Perhaps, even, the caller is buggy?

Not really.

Thanks for explaining! So, isn't bfd_fdopenr still buggy, then? No more buggy than before, but still buggy, in that it calls bfd_set_error at the top of the function, and never clears it? Should we move the bfd_set_error call there into the "if (fdflags == -1)" case?

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

References:
- Re: [RFA:] ar test failure fix
  - From: Hans-Peter Nilsson
- Re: [RFA:] ar test failure fix
  - From: Mark Mitchell
- Re: [RFA:] ar test failure fix
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]