This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Naming consistency in bfd/elf32-hppa.c
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: carlos at systemhalted dot org (Carlos O'Donell)
- Cc: binutils at sources dot redhat dot com, dave dot anglin at nrc-cnrc dot gc dot ca, tausq at debian dot org
- Date: Tue, 21 Jun 2005 10:21:51 -0400 (EDT)
- Subject: Re: [PATCH] Naming consistency in bfd/elf32-hppa.c
> Please apply.
>
> 2005-06-20 Carlos O'Donell <carlos@systemhalted.org>
>
> * bfd/elf32-hppa.c (hppa_elf_hash_entry): Define.
> (hppa_stub_hash_entry): Define.
> (stub_hash_newfunc): Rename variables.
> (hppa_link_hash_newfunc): Likewise.
> (elf32_hppa_link_hash_table_free): Likewise.
> (hppa_stub_name): Likewise.
> (hppa_get_stub_entry): Likewise.
> (hppa_add_stub): Likewise.
> (hppa_type_of_stub): Likewise.
> (hppa_build_one_stub): Likewise.
> (hppa_size_one_stub): Likewise.
> (elf32_hppa_create_dynamic_sections): Likewise.
> (elf32_hppa_copy_indirect_symbol): Likewise.
> (elf32_hppa_check_relocs): Likewise.
> (elf32_hppa_gc_mark_hook): Likewise.
> (elf32_hppa_gc_sweep_hook): Likewise.
> (elf32_hppa_grok_psinfo): Likewise.
> (elf32_hppa_hide_symbol): Likewise.
> (elf32_hppa_adjust_dynamic_symbol): Likewise.
> (allocate_dynrelocs): Likewise.
> (clobber_millicode_symbols): Likewise.
> (readonly_dynrelocs): Likewise.
> (elf32_hppa_size_dynamic_sections): Likewise.
> (get_local_syms): Likewise.
> (elf32_hppa_size_stubs): Likewise.
> (hppa_record_segment_addr): Likewise.
> (final_link_relocate): Likewise.
> (elf32_hppa_relocate_section): Likewise.
> (elf32_hppa_finish_dynamic_symbol): Likewise.
Installed.
As noted in private mail, there are some struct field names could be
updated to follow your naming convention. For example,
/* The symbol table entry, if any, that this was derived from. */
struct elf32_hppa_link_hash_entry *h;
to
/* The symbol table entry, if any, that this was derived from. */
struct elf32_hppa_link_hash_entry *hh;
It would be greatly appreciated if these could be updated as well.
Thanks,
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)