This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] bfd robustification (avoid crashes on bogus ararchives)
- From: Nick Clifton <nickc at redhat dot com>
- To: jakub at redhat dot com
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 04 Jul 2005 16:15:53 +0100
- Subject: Re: [PATCH] bfd robustification (avoid crashes on bogus ararchives)
Hi Jakub,
> 2005-06-21 Jakub Jelinek <jakub@redhat.com>
>
> * libbfd-in.h (struct artdata): Add extended_names_size field.
> * libbfd.h: Rebuilt.
> * coff-rs600.c (_bfd_xcoff_archive_p): Don't clear fields in freshly
> allocated object by bfd_zalloc.
> * coff64-rs6000.c (xcoff64_archive_p): Likewise.
> * ecoff.c (_bfd_ecoff_archive_p): Likewise.
> * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p): Likewise.
> (get_extended_arelt_filename): Fail if index is bigger or equal to
> extended_names_size.
> (_bfd_generic_read_ar_hdr_mag): Don't set bfd_error_malformed_archive,
> get_extended_arelt_filename already did that.
> (_bfd_slurp_extended_name_table): Initialize extended_names_size field.
> Allocate one extra byte and clear it, in case extended names table
> is not terminated.
Approved - please apply.
Cheers
Nick