This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: fix dwarf2 handling of signed addresses

From: Eric Christopher <echristo at redhat dot com>
To: Daniel Jacobowitz <drow at false dot org>
Cc: Paul Koning <pkoning at equallogic dot com>, binutils at sources dot redhat dot com
Date: Fri, 08 Jul 2005 09:14:50 -0700
Subject: Re: PATCH: fix dwarf2 handling of signed addresses
References: <17101.42311.275302.777084@gargle.gargle.HOWL> <17102.41161.857750.187469@gargle.gargle.HOWL> <1120838529.9164.6.camel@dzur.sfbay.redhat.com> <20050708160625.GA21456@nevyn.them.org>

> > My only reservation for this is that we should be sign extending every
> > address no matter what and that this points to a bug in our code
> > elsewhere.
> 
> Are you sure?  Remember, many targets zero extend - Paul's patch looks
> sensible to me.
> 

Of course it's fine, it's in target independent code. I really shouldn't
review the first thing in the morning. :) That said, that it fixes code
in mips still makes me feel wonky.

-eric

References:
- Why mips32 addr2line doesn't work
  - From: Paul Koning
- PATCH: fix dwarf2 handling of signed addresses
  - From: Paul Koning
- Re: PATCH: fix dwarf2 handling of signed addresses
  - From: Eric Christopher
- Re: PATCH: fix dwarf2 handling of signed addresses
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]