This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] x86: fix gas' relocation type selection
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 18 Jul 2005 07:59:19 -0700
- Subject: Re: [PATCH] x86: fix gas' relocation type selection
- References: <s2db5f12.002@lucius.provo.novell.com>
On Mon, Jul 18, 2005 at 07:50:21AM -0600, Jan Beulich wrote:
> Relocation type selection up to now was dependent on the current code
> size
> model, but it instead should exclusively depend on the output file
> format
> (for example, even when in 64-bit code but in a 32-bit object, i386
> relocations should be used rather than x86-64 ones [or perhaps a
> mixture of
> both]).
>
There are
case bfd_target_elf_flavour:
{
if (flag_code == CODE_64BIT)
use_rela_relocations = 1;
I don't see how your patch will change anything. And I don't like
using use_rela_relocations for 64bit mode checking. It makes code
less readable.
H.J.