This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: gas configure cleanup
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: sje at cup dot hp dot com (Steve Ellcey)
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 18 Jul 2005 19:48:33 -0400 (EDT)
- Subject: Re: gas configure cleanup
> Can we just ansify the prototype and make them correct? We only use
I believe that's tricky and the reason that full prototypes weren't
provided in the first place.
> -Werror if building with GCC and I assume that it is the lack of an
> argument list that generates the warning. PTR is a #define for 'void *'
Yes, it's the lack of an argument list that's the problem.
> in src/include/ansidecl.h (char *, if _STDC_ is not set) so the return
> type should be OK if compiling with GCC and _STDC_ is set.
> src/gas/hash.h is already using size_t with no ifdef's around it. I
> assume we would need to ansify the rest of them too (free, ffs, etc).
Yes.
> You can also configure with --diable-werror to allow compilation with
> warnings.
That's true. However, it's a bit annoying to the user when compilation
fails with the default configure options. That's why I suggested
automatically turning off werror when a declaration with ambiguous
arguments is needed.
> At any rate, I don't believe my patch makes this problem better or worse
> than it is now.
Yes, I simply wanted to raise the issue in the hope of improving the
current situation.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)