This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] x86: adjust immediate instruction operands handling
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 26 Jul 2005 08:04:37 -0700
- Subject: Re: [PATCH] x86: adjust immediate instruction operands handling
- References: <s2e5f80c.020@lucius.provo.novell.com>
On Tue, Jul 26, 2005 at 08:45:59AM -0600, Jan Beulich wrote:
> >>> "H. J. Lu" <hjl@lucon.org> 18.07.05 16:56:16 >>>
> >On Mon, Jul 18, 2005 at 08:06:19AM -0600, Jan Beulich wrote:
> >> Until now, it was possible to use, for example (Intel Syntax),
> >>
> >> shl <byte-reg>, <imm8>
> >>
> >> where <imm8> was either a forward reference or even an external
> >> absolute.
> >> However, it wasn't possible to do the same with 16-, 32-, or 64-bit
> >> registers, because the immediate's size and the register and/or
> suffix
> >> didn't match in size. This patch makes this consistent so that all
> >> forms
> >> get accepted.
> >
> >A testcase?
>
> Included this time.
>
> Built and tested on i386-pc-linux-gnu and x86_64-unknown-linux-gnu.
>
> Jan
>
> gas/
> 2005-07-26 Jan Beulich <jbeulich@novell.com>
>
> * config/tc-i386.c (optimize_imm): Calculate candidate
> immediates
> mask from guessed suffix, but mask out other immediate types
> only
> if at least on candidate is valid for the insn.
>
> gas/testsuite/
> 2005-07-26 Jan Beulich <jbeulich@novell.com>
>
> * gas/i386/immed32.[sd]: New.
> * gas/i386/immed64.[sd]: New.
> * gas/i386/i386.exp: Run new tests.
>
OK. Thanks.
H.J.