This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix benign ld testsuite failures on arm-elf

Recent changes to the linker have caused some of the ARM linker tests to
start reporting failures.  Specifically, the change to the way symbols
in deleted sections are now put in the absolute section means that
_stack is now placed in the ABS section.  This caused a number of minor
differences in the dump logs which of course then result in failures.

I've fixed _stack to now be expected in the ABS section.  This seems to
be the 'right thing'.  The other changes were simply to offsets in the
files for dumps of a shared library.  These addresses have changed
because the hash tables have changed as a consequence of this.  It seems
that these tests shouldn't really be relying on the dumped code
appearing at some specific address, so I've changed the tests to be more
general.

Tested on arm-elf and installed.

R.

2005-08-08  Richard Earnshaw  <richard.earnshaw@arm.com>

	* ld-arm/mixed-app.sym: Expact _stack to be in the ABS section.
	* ld-arm/mixed-lib.sym: Likewise.
	* tls-lib.d: Use a regexp for the address locations.
	* tls-lib.r: Likewise.



Index: mixed-app.sym
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/mixed-app.sym,v
retrieving revision 1.1
diff -p -r1.1 mixed-app.sym
*** mixed-app.sym	17 Nov 2004 17:50:27 -0000	1.1
--- mixed-app.sym	8 Aug 2005 15:44:09 -0000
*************** Symbol table for image:
*** 7,13 ****
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _bss_end__
     ..  ..: ........     0  OBJECT GLOBAL DEFAULT ABS _DYNAMIC
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_end__
!    ..  ..: ........     0  NOTYPE GLOBAL DEFAULT  13 _stack
     ..  ..: ........     4  OBJECT GLOBAL DEFAULT  12 data_obj
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start__
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start
--- 7,13 ----
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _bss_end__
     ..  ..: ........     0  OBJECT GLOBAL DEFAULT ABS _DYNAMIC
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_end__
!    ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _stack
     ..  ..: ........     4  OBJECT GLOBAL DEFAULT  12 data_obj
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start__
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start
Index: mixed-lib.sym
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/mixed-lib.sym,v
retrieving revision 1.3
diff -p -r1.3 mixed-lib.sym
*** mixed-lib.sym	16 Mar 2005 21:52:46 -0000	1.3
--- mixed-lib.sym	8 Aug 2005 15:44:09 -0000
*************** Symbol table for image:
*** 7,13 ****
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _bss_end__
     ..  ..: ........     0  OBJECT GLOBAL DEFAULT ABS _DYNAMIC
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_end__
!    ..  ..: ........     0  NOTYPE GLOBAL DEFAULT  10 _stack
     ..  ..: ........     4  OBJECT GLOBAL DEFAULT   9 data_obj
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start__
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start
--- 7,13 ----
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _bss_end__
     ..  ..: ........     0  OBJECT GLOBAL DEFAULT ABS _DYNAMIC
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_end__
!    ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS _stack
     ..  ..: ........     4  OBJECT GLOBAL DEFAULT   9 data_obj
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start__
     ..  ..: ........     0  NOTYPE GLOBAL DEFAULT ABS __bss_start
Index: tls-lib.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/tls-lib.d,v
retrieving revision 1.3
diff -p -r1.3 tls-lib.d
*** tls-lib.d	8 Jul 2005 06:22:02 -0000	1.3
--- tls-lib.d	8 Aug 2005 15:44:09 -0000
*************** start address 0x.*
*** 6,15 ****
  
  Disassembly of section .text:
  
! 00000314 <foo>:
!  314:	e1a00000 	nop			\(mov r0,r0\)
!  318:	e1a00000 	nop			\(mov r0,r0\)
!  31c:	e1a0f00e 	mov	pc, lr
!  320:	00008098 	muleq	r0, r8, r0
!  324:	0000808c 	andeq	r8, r0, ip, lsl #1
!  328:	00000004 	andeq	r0, r0, r4
--- 6,15 ----
  
  Disassembly of section .text:
  
! .* <foo>:
!  .*:	e1a00000 	nop			\(mov r0,r0\)
!  .*:	e1a00000 	nop			\(mov r0,r0\)
!  .*:	e1a0f00e 	mov	pc, lr
!  .*:	00008098 	muleq	r0, r8, r0
!  .*:	0000808c 	andeq	r8, r0, ip, lsl #1
!  .*:	00000004 	andeq	r0, r0, r4
Index: tls-lib.r
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/tls-lib.r,v
retrieving revision 1.3
diff -p -r1.3 tls-lib.r
*** tls-lib.r	8 Jul 2005 06:22:03 -0000	1.3
--- tls-lib.r	8 Aug 2005 15:44:09 -0000
***************
*** 3,10 ****
  
  DYNAMIC RELOCATION RECORDS
  OFFSET   TYPE              VALUE 
! 000083b0 R_ARM_TLS_DTPMOD32  \*ABS\*
! 000083b8 R_ARM_TLS_DTPMOD32  lib_gd
! 000083bc R_ARM_TLS_DTPOFF32  lib_gd
  
  
--- 3,10 ----
  
  DYNAMIC RELOCATION RECORDS
  OFFSET   TYPE              VALUE 
! .* R_ARM_TLS_DTPMOD32  \*ABS\*
! .* R_ARM_TLS_DTPMOD32  lib_gd
! .* R_ARM_TLS_DTPOFF32  lib_gd
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]