This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix benign ld testsuite failures on arm-elf


On Mon, Aug 08, 2005 at 04:52:58PM +0100, Richard Earnshaw wrote:
> I've fixed _stack to now be expected in the ABS section.  This seems to
> be the 'right thing'.  The other changes were simply to offsets in the
> files for dumps of a shared library.  These addresses have changed
> because the hash tables have changed as a consequence of this.  It seems
> that these tests shouldn't really be relying on the dumped code
> appearing at some specific address, so I've changed the tests to be more
> general.

I was trying to test that the relocations were put in the right places
in the GOT.  It does make the tests a bear to maintain, but it also
makes them more thorough... I did get this wrong a couple times while
working on TLS.

In any case:

> !  .*:	00008098 	muleq	r0, r8, r0
> !  .*:	0000808c 	andeq	r8, r0, ip, lsl #1

If you don't want to rely on the offsets, you'd better change those
too.  I believe they're pcrel displacements to the GOT entries.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]