Re: [PATCH] z8k bfd assembler changes

[Nick Clifton <nickc at redhat dot com>]

Hi Christian,

> The following patch implements bfd assembler support for the z8k
> target.

Approved and applied.

> The other change is in bfd_install_relocation. It now doesn't set
> reloc_entry->addend to 0 for the z8k target anymore.
> Since the comment just above the patch makes my head whirl, and I see
> some prior art of target specific hacks there, I've added a similar
> hack.

I have allowed this although I do not particularly like it.  But as you 
say there are already other target specific code segments in this 
function and besides this is a well known problem area.  Really this 
code ought to be thoroughly rewritten.

> I've applied the change to bfd/configure.in manually to bfd/configure,
> since after regenerating bfd/configure there were many other unrelated
> diffs. What's the correct version of autoconf to regenerate?

2.59.  You can always tell be looking at the start of the configure 
file.  It includes a header which specifies which version of autoconf 
was used to generate it.  [Also as an aside you do not need to include 
the patches to automatically generated files like this in your 
submission.  It is enough to mention that they are regenerated in the 
ChangeLog(s) and leave it up to whomever checks the patch in to 
regenerate them].

Cheers
  Nick