Re: [patch] Readelf dumping of Arm EABI attributes section

[Richard Earnshaw <rearnsha at gcc dot gnu dot org>]

On Sun, 2005-09-11 at 15:16, Paul Brook wrote:
> The attached patch adds readelf support for the ARM EABI object attributes 
> section. The format of this section is described here:
> 
> http://www.arm.com/miscPDFs/8693.pdf
> 
> Tested with cross to arm-none-eabi.
> Ok?
> 
> Paul
> 
> 2005-09-11  Paul Brook  <paul@codesourcery.com>
> 
> 	* readelf.c (arm_attr_tag_CPU_arch, arm_attr_tag_ARM_ISA_use,
> 	arm_attr_tag_THUMB_ISA_use, arm_attr_tag_VFP_arch,
> 	arm_attr_tag_WMMX_arch, arm_attr_tag_NEON_arch,
> 	arm_attr_tag_ABI_PCS_config, arm_attr_tag_ABI_PCS_R9_use,
> 	arm_attr_tag_ABI_PCS_RW_data, arm_attr_tag_ABI_PCS_RO_DATA,
> 	arm_attr_tag_ABI_PCS_GOT_use, arm_attr_tag_ABI_PCS_wchar_t,
> 	arm_attr_tag_ABI_FP_rounding, arm_attr_tag_ABI_FP_denormal,
> 	arm_attr_tag_ABI_FP_exceptions, arm_attr_tag_ABI_FP_user_exceptions,
> 	arm_attr_tag_ABI_FP_number_model, arm_attr_tag_ABI_align8_needed,
> 	arm_attr_tag_ABI_align8_preserved, arm_attr_tag_ABI_enum_size,
> 	arm_attr_tag_ABI_HardFP_use, arm_attr_tag_ABI_VFP_args,
> 	arm_attr_tag_ABI_WMMX_args, arm_attr_tag_ABI_optimization_goals,
> 	arm_attr_tag_ABI_FP_optimization_goals, arm_attr_public_tags): New.
> 	(display_arm_attribute, process_arm_specific: New functions.
> 	(process_arch_specific): Add EM_ARM.

This is OK from an ARM perspective.  I'm not sure if you need a general
maintainer to approve it though, since it's to a generic file.

One stylistic comment: the gnu coding standards say that there should be
blank lines after break/return in a switch statement (except perhaps in
trivial switch tables).  And similarly at the end of for loops or
if-...-else sequences.

R.