This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] fix buffer overflow in windres


Hi Thomas,

There's a buffer overflow in res_to_bin_accelerator() where a word is
written outside of the range of the allocated memory. There's a bugfix
for this already (bug #1259) but instead of fixing the real issue, it
just increases the size of the buffer.

The attached patch should fix the bug correctly.

Thanks for sending us this patch. I have applied it along with this ChangeLog entry:

binutils/ChangeLog2005-10-10 Thomas Weidenmueller <w3seek@reactos.com>

	* resbin.c (res_to_bin_accelerator): Place the terminating NUL at
	the correct location in the bindata structure.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]