This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] fix buffer overflow in windres
- From: Nick Clifton <nickc at redhat dot com>
- To: Thomas Weidenmueller <w3seek at reactos dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 10 Oct 2005 17:04:28 +0100
- Subject: Re: [patch] fix buffer overflow in windres
- References: <434A880E.7070305@reactos.com>
Hi Thomas,
There's a buffer overflow in res_to_bin_accelerator() where a word is
written outside of the range of the allocated memory. There's a bugfix
for this already (bug #1259) but instead of fixing the real issue, it
just increases the size of the buffer.
The attached patch should fix the bug correctly.
Thanks for sending us this patch. I have applied it along with this
ChangeLog entry:
binutils/ChangeLog2005-10-10 Thomas Weidenmueller <w3seek@reactos.com>
* resbin.c (res_to_bin_accelerator): Place the terminating NUL at
the correct location in the bindata structure.
Cheers
Nick