This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [AVR][PATCH] Add linker relaxation support / Fix 64 bit bug ingas rev. 3
- From: Nick Clifton <nickc at redhat dot com>
- To: Björn Haase <bjoern dot m dot haase at web dot de>
- Cc: binutils at sourceware dot org, Marek Michalkiewicz <marekm at amelek dot gda dot pl>
- Date: Tue, 25 Oct 2005 12:30:52 +0100
- Subject: Re: [AVR][PATCH] Add linker relaxation support / Fix 64 bit bug ingas rev. 3
- References: <200510151652.33552.bjoern.m.haase@web.de> <200510250028.46043.bjoern.m.haase@web.de>
Hi Björn,
this is the third revision for my suggestions concerning linker relaxation
support for avr. I have meanwhile run quite a number of tests so that I
think it is suitable for mainline binutils. I have also now received the
copyright assignment for binutils.
Sorry - this patch introduces two new failures in the GAS testsuite for
the avr-elf toolchain:
Running /sources/binutils/current/gas/testsuite/gas/all/gas.exp ...
FAIL: difference of two undefined symbols
FAIL: difference between forward references
I suspect that these failures are due to the fact that you no longer
allow any fixups to be adjusted. Please could you look at these
failures and work out if your patch can be adjusted to avoid them.
I also have made use of <inttypes.h> in order to fix a bug that shows up
for 64 bit machines for present mainline.
You should only use this header if HAVE_INTTYPES_H is defined. If it is
not defined you should provide an alternative definition of the types
that you are using.
Cheers
Nick