This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Date: Fri, 28 Oct 2005 19:06:33 +0200
- Subject: Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
(Bounced from binutils@sources.redhat.com, retrying.)
> Date: Fri, 28 Oct 2005 09:37:15 -0700
> From: "H. J. Lu" <hjl@lucon.org>
> I don't think
>
> http://sourceware.org/ml/binutils/2005-10/msg00427.html
>
> is correct. complain_overflow_bitfield will fail for all 32bit targets
> with 32bit RELA relocations when 64bit bfd_vma is used.
Well, I *did* indicate that something in the direction you're
heading was better (thanks for looking into it)...
> _bfd_relocate_contents has support for 32bit REL relocations, but not
> RELA relocations. This patch should work.
... but it's not really *wrong* to disable overflow-checking on
that reloc in elf32-cris.c because there *can be* no overflow
for 32-bit arithmetic in 32-bit ELF. (Note that "32-bit" is the
GCC spelling convention, so we'd better use that.)
So, I'd rather keep the elf32-cris.c bits, don't apply that
part, please.
brgds, H-P