This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] MIPS: Add mips16e save/restore instruction support.
David Ung wrote:
[snip]
> * mips.h: Assign 'm'/'M' codes to MIPS16e save/restore
> instructions. Define MIPS16_ALL_ARGS and MIPS16_ALL_STATICS for
> save/restore encoding of the args field.
>
> * mips16-opc.c: Add MIPS16e save/restore opcodes.
> * mips-dis.c (print_mips16_insn_arg): Handle printing of 'm'/'M'
> codes for save/restore.
>
> * config/tc-mips.c (mips16_ip): Add handling of 'm' and 'M' codes
> for the MIPS16e save/restore instructions.
>
> * gas/mips/mips.exp: Run new save/restore tests.
> * gas/testsuite/gas/mips/mips16e-save.s: New test for generating
> different styles of save/restore instructions.
> * gas/testsuite/gas/mips/mips16e-save.d: New.
Approved and applied with minimal changes:
[snip]
> + #define SKIP_SPACE_TABS(S) { while (*S == ' ' || *S == '\t') ++S; }
> +
Parentheses around the argument uses.
[snip]
> Index: gas/testsuite/gas/mips/mips16e-save.d
> ===================================================================
> #objdump: -dr -mmips:isa32 -mmips:16
> #as: -march=mips32 -mips16
> #name: mips16e save/restore
> .*: file format .*
File format of .*mips.*
> Disassembly of section .text:
> 00000000 <func>:
> 0: 6481 save 8
An whitespace regex [ ]+, which is a bit more robust.
Thiemo