Re: [RFA/hpux] Implement file_matches_executable_p

[Joel Brobecker <brobecker at adacore dot com>]

> Very simple: you grep for file_matches_executable_p :-)  If anyone
> didn't give theirs the obvious name, well, too bad for them.

Oh no :-). This is the answer I didn't want to hear. Is this OK if
I do this in a separate patch? I'm working on it right now, but
this breaks down a bit the size of the overall change.

> You can just do this instead:
> #define hpux_core_file_matches_executable_p generic_core_file_matches_executable_p

Clever. Implemented as suggested.

One bad point for me, I knew that libbfd.h was generated. For some
reason I forgot to include libbfd-in.h in the patch.

I also implemented AlanM's suggestion of losing a macro and expanding
it manually.

2005-11-17  Joel Brobecker  <brobecker@adacore.com>

        * corefile.c (generic_core_file_matches_executable_p): New function.
        * libbfd-in.h (generic_core_file_matches_executable_p): Add
        declaration.
        * libbfd.h: Regenerate.
        * hpux-core.c: ANSIfy function declarations and prototypes.
        (thread_section_p): Manually expand bfd_section_name macro
        to make it clear that parameter ABFD is not used.
        (hpux_core_core_file_matches_executable_p): Delete, replaced
        by macro pointing to generic_core_file_matches_executable_p.

Now, on to the other maches_executable_p function bodies...

-- 
Joel

Attachment: hpux.diff
Description: Text document