This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR gas/2117: IA64 assembler is broken


On Mon, Jan 09, 2006 at 10:53:41AM +0100, Jan Beulich wrote:
> >--- gas/symbols.c.equ	2005-12-24 08:16:57.000000000 -0800
> >+++ gas/symbols.c	2006-01-06 17:40:57.000000000 -0800
> >@@ -1399,7 +1399,9 @@ snapshot_symbol (symbolS **symbolPP, val
> > 	    }
> > 	}
> > 
> >-      *symbolPP = symbolP;
> >+      /* Never change a defined symbol.  */
> >+      if (symbolP->bsym->section == undefined_section)
> >+	*symbolPP = symbolP;
> >       *valueP = expr.X_add_number;
> >       *segP = symbolP->bsym->section;
> >       *fragPP = symbolP->sy_frag;
> 
> The minimum, as I view it, is to also include expr_section symbols
> here. Beyond that, assuming that you already checked that no existing
> test case breaks, I hope this change will not have other ill effects.

The old code doesn't include expr_section symbols. I don't think we
should change it unless we have a testcase to show it is necessary.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]