This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: IA64 HP-UX workaround for HP linker bug.


On Thu, 2006-02-02 at 16:22, Steve Ellcey wrote:
> 	* elf/ia64.h (SHF_IA_64_HP_TLS): New.
> 	* bfd/elfxx-ia64.c (elfNN_ia64_fake_sections): Set SHF_IA_64_HP_TLS
> 	if SHF_TLS is set.

This is OK with me.

I noticed that the SHF_IA_64_HP_TLS bit is in the OS reserved section,
not the processor reserved section.  This implies that perhaps this bit
should be in a new elf/hpux.h file, which is then used by both the PA
and IA-64 targets.  However, I see that the mips.h file has some similar
OS specific bits defined there, so it appears to be OK to do the same
thing in the ia64.h file.

If this is something we may want to remove later, then some info should
be included in comments, so we can tell when it is safe to remove it. 
For instance, mentioning which HP linker versions need it.

You should add a blank line after the SHF_IA_64_HP_TLS definition.
-- 
Jim Wilson, GNU Tools Support, http://www.specifix.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]