This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: PATCH: ld/2338: objdump -d -l doesn't work correctly
- From: "Dave Korn" <dave dot korn at artimi dot com>
- To: "'H. J. Lu'" <hjl at lucon dot org>, "'Andreas Schwab'" <schwab at suse dot de>
- Cc: "'Andrew Morton'" <akpm at osdl dot org>, <binutils at sources dot redhat dot com>
- Date: Wed, 15 Feb 2006 12:29:52 -0000
- Subject: RE: PATCH: ld/2338: objdump -d -l doesn't work correctly
On 14 February 2006 23:24, H. J. Lu wrote:
> On Tue, Feb 14, 2006 at 11:54:05PM +0100, Andreas Schwab wrote:
>> "H. J. Lu" <hjl@lucon.org> writes:
>>
>>> +/* Return FALSE if FUNC in symbol table SYMBOLS is not relative to
>>> + SECTION. */
>>
>> Double negation is not easy to not misunderstand.
>>
>
> I am trying to say that only FALSE return is reliable since TRUE can
> return under other conditions. Maybe I should change the function
> name to function_name_section_mismatch.
Or how about wording it the other way round?
/* Return TRUE if FUNC in symbol table SYMBOLS is relative to SECTION. */
cheers,
DaveK
--
Can't think of a witty .sigline today....