This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
On Tue, Feb 21, 2006 at 03:12:41PM -0500, Daniel Jacobowitz wrote:
> On Tue, Feb 21, 2006 at 11:46:09AM -0800, H. J. Lu wrote:
> > On Tue, Feb 21, 2006 at 12:32:26AM +0100, Eric Botcazou wrote:
> > > > _bfd_dwarf2_find_nearest_line can't tell the line number when more
> > > > than one lines have the same address.
> > >
> > > Yes, that was also the underlying problem with objdump -d -l.
> > >
> > > > I will see if I can implement Dan's approach when I find the time.
> > >
> > > Clearly the way to go. But since the relocations are not yet resolved in the
> > > debug info sections, I think you'll have to resolve them manually.
> > >
> >
> > Here is the patch. It seems to work on all testcases I have.
>
> Seems sensible, but do we need to un-set the vmas when we're done?
> Will they get back to the linker somehow?
I am not sure if it really matters since we already call
bfd_simple_get_relocated_section_contents which it may do more
damage than setting vma.
H.J.