This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
fix Xtensa --text-section-literals option for GNU/Linux
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Mon, 06 Mar 2006 11:16:04 -0800
- Subject: fix Xtensa --text-section-literals option for GNU/Linux
It appears that I broke the Xtensa assembler's --text-section-literals option
for GNU/Linux over a year ago. I changed the linker to require that all dynamic
relocations be inside marked literal pools, but the assembler has not been
marking those literal pools when using the --text-section-literals option. This
patch simply changes gas to always mark the literal pools. Tested by linking a
small program built with --text-section-literals for an xtensa-linux target, and
also by running the testsuite for an xtensa-elf target. Committed on the mainline.
2006-03-06 Bob Wilson <bob.wilson@acm.org>
* config/tc-xtensa.c (xtensa_post_relax_hook): Generate literal tables
even when using the text-section-literals option.
Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.57
diff -u -p -r1.57 tc-xtensa.c
--- config/tc-xtensa.c 14 Feb 2006 00:58:05 -0000 1.57
+++ config/tc-xtensa.c 6 Mar 2006 17:32:07 -0000
@@ -10078,11 +10078,10 @@ xtensa_post_relax_hook (void)
xtensa_find_unmarked_state_frags ();
- if (use_literal_section)
- xtensa_create_property_segments (get_frag_is_literal,
- NULL,
- XTENSA_LIT_SEC_NAME,
- xt_literal_sec);
+ xtensa_create_property_segments (get_frag_is_literal,
+ NULL,
+ XTENSA_LIT_SEC_NAME,
+ xt_literal_sec);
xtensa_create_xproperty_segments (get_frag_property_flags,
XTENSA_PROP_SEC_NAME,
xt_prop_sec);