This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[Xtensa] avoid extra entries in literal tables
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Tue, 25 Apr 2006 09:37:49 -0700
- Subject: [Xtensa] avoid extra entries in literal tables
The Xtensa literal tables (e.g., .xt.lit sections) are not relevant for
"absolute-mode" literals (e.g., in .lit4 sections), but in some cases, literal
table entries were being generated for them anyway. This patch changes GAS so
that the "is_literal" flag is only set by the mark_literal_frags() function.
Tested with an xtensa-elf target and committed on the mainline and 2.17 branch.
2006-04-25 Bob Wilson <bob.wilson@acm.org>
* config/tc-xtensa.c (xtensa_create_literal_symbol,
xg_assemble_literal, xg_assemble_literal_space): Do not set the
frag's is_literal flag.
Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.64
diff -u -p -r1.64 tc-xtensa.c
--- config/tc-xtensa.c 23 Apr 2006 22:12:43 -0000 1.64
+++ config/tc-xtensa.c 25 Apr 2006 15:49:51 -0000
@@ -3980,7 +3980,6 @@ xtensa_create_literal_symbol (segT sec,
xtensa_add_literal_sym (symbolP);
- frag->tc_frag_data.is_literal = TRUE;
lit_num++;
return symbolP;
}
@@ -4046,7 +4045,6 @@ xg_assemble_literal (/* const */ TInsn *
frag_now->tc_frag_data.literal_frag = get_literal_pool_location (now_seg);
frag_now->fr_symbol = xtensa_create_literal_symbol (now_seg, frag_now);
lit_sym = frag_now->fr_symbol;
- frag_now->tc_frag_data.is_literal = TRUE;
/* Go back. */
xtensa_restore_emit_state (&state);
@@ -4075,7 +4073,6 @@ xg_assemble_literal_space (/* const */ i
lit_saved_frag = frag_now;
frag_now->tc_frag_data.literal_frag = get_literal_pool_location (now_seg);
- frag_now->tc_frag_data.is_literal = TRUE;
frag_now->fr_symbol = xtensa_create_literal_symbol (now_seg, frag_now);
xg_finish_frag (0, RELAX_LITERAL, 0, size, FALSE);
@@ -4230,7 +4227,6 @@ xg_resolve_labels (TInsn *insn, symbolS
{
symbolS *sym = get_special_label_symbol ();
int i;
- /* assert (!insn->is_literal); */
for (i = 0; i < insn->ntok; i++)
if (insn->tok[i].X_add_symbol == sym)
insn->tok[i].X_add_symbol = label_sym;