This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got
- From: "H. J. Lu" <hjl at lucon dot org>
- To: binutils at sources dot redhat dot com
- Date: Tue, 25 Apr 2006 18:26:44 -0700
- Subject: Re: PATCH: gas/2598: Build kernel 2.6.16 modules with gcc 4.0.2 Warning: setting incorrect section attributes for .got
- References: <20060425222618.GA32676@lucon.org>
On Tue, Apr 25, 2006 at 03:26:18PM -0700, H. J. Lu wrote:
> Gcc may generate a section with SHF_ALPHA_GPREL. Assembler shouldn't
> complain. This patch does it.
>
>
I am not really sure if SHF_ALPHA_GPREL is really needed. This is the
updated patch to properly allow it.
H.J.
---
2006-04-25 H.J. Lu <hongjiu.lu@intel.com>
PR gas/2598
* config/obj-elf.c (obj_elf_change_section): Allow user
specified SHF_ALPHA_GPREL.
--- gas/config/obj-elf.c.alpha 2005-09-26 12:13:55.000000000 -0700
+++ gas/config/obj-elf.c 2006-04-25 18:16:36.000000000 -0700
@@ -632,6 +632,11 @@ obj_elf_change_section (const char *name
else if (attr == SHF_EXECINSTR
&& strcmp (name, ".note.GNU-stack") == 0)
override = TRUE;
+#ifdef TC_ALPHA
+ /* A section on Alpha may have SHF_ALPHA_GPREL. */
+ else if ((attr & ~ssect->attr) == SHF_ALPHA_GPREL)
+ override = TRUE;
+#endif
else
{
if (group_name == NULL)