This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Thumb-2 conditional execution disassembly
- From: Daniel Jacobowitz <drow at false dot org>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 29 Apr 2006 20:15:17 -0400
- Subject: Re: [patch] Thumb-2 conditional execution disassembly
- References: <200604291851.20562.paul@codesourcery.com>
On Sat, Apr 29, 2006 at 06:51:18PM +0100, Paul Brook wrote:
> +/* Current IT instruction state. This conatins the same state as the IT
Typo, "contains".
> + bits in the CPSR. */
> +static unsigned int ifthen_state;
> +/* IT state for the next instruction. */
> +static unsigned int ifthen_next_state;
> +/* The address of the insn for which the IT state is valid. */
> +static bfd_vma ifthen_address;
> +#define IFTHEN_COND ((ifthen_state >> 4) & 0xf)
Isn't there somewhere in the dissassembler state that you can put
these? And even then I'm a little concerned about the way you're
caching. In objdump, the contents of memory can be counted on to stay
stable; but in GDB they can't - if the program runs between two
disassemblies at the same PC, the text area may change.
Of course, it rarely does...
--
Daniel Jacobowitz
CodeSourcery