This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Arm BE8 mode and mapping sybols
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Paul Brook <paul at codesourcery dot com>, binutils at sourceware dot org
- Date: Mon, 08 May 2006 13:14:46 +0100
- Subject: Re: [patch] Arm BE8 mode and mapping sybols
- References: <200605052247.59076.paul@codesourcery.com> <445E0813.9030005@redhat.com>
On Sun, 2006-05-07 at 15:45, Nick Clifton wrote:
> Hi Paul,
>
> > + /* We only want 'a', 't' and 'd' mapping symbols. */
> > + if (! bfd_is_arm_mapping_symbol_name (name)
> > + || (name[1] != 'a' && name[1] != 't' && name[1] != 'd'))
> > return TRUE;
>
> Actually I think that it would be cleaner if
> bfd_is_arm_mapping_symbol_name() took a second argument which
> distinguishes between a request for any mapping symbol versus a request
> for only-valid-for-modern-ABIs mapping symbol. That way the knowledge
> about which symbols are valid can be kept in one place, with the code
> that actually detects them.
>
> Cheers
> Nick
There have only ever been three mapping symbols: $a, $t and $d. The
remainder have always been 'tagging' symbols. Maybe the routine should
be renamed to bfd_is_arm_special_symbol name and then given an argument
TYPE_MAP, TYPE_TAG or TYPE_ANY.
R.