This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects

From: Julian Brown <julian at codesourcery dot com>
To: Alan Modra <amodra at bigpond dot net dot au>
Cc: binutils at sourceware dot org, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Paul Brook <paul at codesourcery dot com>
Date: Thu, 25 May 2006 17:53:31 +0100
Subject: Re: [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects
References: <44746112.1000203@codesourcery.com> <20060525050107.GF25824@bubble.grove.modra.org> <20060525145627.GH25824@bubble.grove.modra.org>

Hi,

Alan Modra wrote:

	* elf.c (sym_is_global): Return a bfd_boolean.
	(ignore_section_sym): New function.
	(elf_map_symbols): Use ignore_section_sym to discard some syms.
	(_bfd_elf_symbol_from_bfd_symbol): Ensure section belongs to
	bfd before using elf_section_syms.

Thanks very much for looking into this! It's far preferable that the fix is in Elf-specific code rather than the generic code, I agree. FYI, this patch fixes the original problem just fine, and I've committed it on our binutils-csl-2_17-branch.

Cheers,

Julian

References:
- [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects
  - From: Julian Brown
- Re: [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects
  - From: Alan Modra
- Re: [PATCH] Fix section symbols in objcopy when removing sections with relocations from Elf objects
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]