This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA:] Re: Ld option -z mistreat (new tests ld-elf/commonpage1 ld-elf/maxpage1 fail for cris-elf arm-elf)


> Date: Wed, 31 May 2006 16:30:40 +0200
> From: Hans-Peter Nilsson <hp@axis.com>

> Inferring that all run_dump-tests using -z options should use
> "#target:" or "#notarget:".

Similarly other tests needing to use the ld -z option, of
course.  Like these one, which get UNRESOLVED otherwise, thus a
nonzero "make check" exit.  These are the only tests in
binutils.exp and there's a is_elf_format test at the top, but
future tests could presumably be added that don't use -z, so I
put the condition close to the test.  Checked cross to
cris-axis-elf.

Ok to commit?

	* ld-elf/binutils.exp: Restrict tests using ld option -z to target
	*-*-linux*.

Index: binutils.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/binutils.exp,v
retrieving revision 1.1
diff -u -p -r1.1 binutils.exp
--- binutils.exp	30 May 2006 16:45:32 -0000	1.1
+++ binutils.exp	31 May 2006 16:22:42 -0000
@@ -76,5 +76,10 @@ proc strip_test { ld_options test } {
     pass "$ld_options"
 }
 
-strip_test "-z max-page-size=0x200000" maxpage1
-strip_test "-z max-page-size=0x200000 -z common-page-size=0x100000" maxpage1
+# Use ld -z options only for GNU/Linux targets; they're unrecognized for
+# targets that don't support dynamic linking.
+
+if [istarget *-*-linux*] {
+    strip_test "-z max-page-size=0x200000" maxpage1
+    strip_test "-z max-page-size=0x200000 -z common-page-size=0x100000" maxpage1
+}

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]