This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Add DWARF debugging format support for arm-wince-pe


On Sat, Aug 05, 2006 at 01:17:47PM +0100, Pedro Alves wrote:
> Ok. Than should I 'else if' ?:
> 
>   if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
>       || strcmp (name, "pe-i386") == 0
>       || strcmp (name, "pei-i386") == 0)
>       return 1;
>   else if (strcmp (name, "pe-arm-little") == 0
>       || strcmp (name, "pei-arm-little") == 0)
>     return 0;
> 
> or, should i386 return 0 too ?:
> 
>   if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
>       || strcmp (name, "pe-i386") == 0
>       || strcmp (name, "pei-i386") == 0
>       || strcmp (name, "pe-arm-little") == 0
>       || strcmp (name, "pei-arm-little") == 0)
>       return 0;
> 
> 
> or, simply leave i386 and arm returning 1, until this hack
> is cleaned up?

I'd do the last option.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]