This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/3197: ld --hash-style=gnu crashes
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 12 Sep 2006 23:58:40 +0200
- Subject: Re: PATCH: ld/3197: ld --hash-style=gnu crashes
- References: <20060912214044.GA10196@lucon.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Sep 12, 2006 at 02:40:44PM -0700, H. J. Lu wrote:
> The problem is that bucketcount isn't set when --hash-style=gnu is
> used. There is no need to compute bucket when it isn't needed.
Looks good. Seems like GCC was already optimizing what you have done
in the patch, otherwise nothing would work (Fedora Core builds the whole
distro except glibc with --hash-style=gnu).
Was this an -O0 build of elflink.c you saw it in?
> 2006-09-12 H.J. Lu <hongjiu.lu@intel.com>
>
> PR ld/3197
> * elflink.c (elf_link_output_extsym): Compute bucket only if
> needed.
Jakub