This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: gas attempting to assemble non-existent file
>>> Alan Modra <amodra@bigpond.net.au> 13.09.06 11:13 >>>
>On Wed, Sep 13, 2006 at 09:41:57AM +0100, Jan Beulich wrote:
>> >>> Alan Modra <amodra@bigpond.net.au> 13.09.06 10:07 >>>
>> >On Wed, Sep 13, 2006 at 07:56:32AM +0100, Jan Beulich wrote:
>> >> Couldn't this be just as_warn()?
>> >
>> >I wrote it that way at first, then decided as_bad is probably better.
>> >An error from fclose might be due to failure to flush file buffers.
>>
>> But we're talking about a file being read here
>
>Duh. Please commit a fix. (Or I will if you don't care to.)
Done:
2006-09-13 Jan Beulich <jbeulich@novell.com>
* input-file.c (input_file_give_next_buffer): Demote as_bad to
as_warn.
--- 2006-09-13/gas/input-file.c 2006-09-13 11:51:35.000000000 +0200
+++ 2006-09-13/gas/input-file.c 2006-09-13 11:58:46.000000000 +0200
@@ -246,7 +246,7 @@ input_file_give_next_buffer (char *where
else
{
if (fclose (f_in))
- as_bad (_("can't close %s: %s"), file_name, xstrerror (errno));
+ as_warn (_("can't close %s: %s"), file_name, xstrerror (errno));
f_in = (FILE *) 0;
return_value = 0;