Re: Regression with strn-stuff

[Nick Clifton <nickc at redhat dot com>]

Hi Hans-Peter,

> Running /h/hp/binutils/cvs_latest/src/ld/testsuite/ld-elf/elf.exp ...
> FAIL: ld-elf/stab

Yes I noticed this failure turning up recently with a number of ports, 
but when I checked I found that it was not connected to the CONST_STRNEQ 
patch but to something else.  (I have not had the time to find out what 
yet).

> -	    if (strncmp (".stab", stab->name, 5) == 0
> +	    if (CONST_STRNEQ (".stab", stab->name)

Oops - thanks - I have checked in a patch to correct this.

> Gotta find a way to automatically check the const-stringness of
> the second operand.  Use __builtin_constant_p in a checking
> macro enabled for gcc?

Is there such a function ?  I did not know, but if it does exist then 
yes, using it would be a good idea.

Cheers
  Nick