Re: [PATCH] LOCAL_LABEL_PREFIX on Windows CE (ARM).

[Pedro Alves <pedro_alves at portugalmail dot pt>]

Pedro Alves escreveu:
> Hi all,
>
> Since we aren't using underscores on Windows CE,
> we must set LOCAL_LABEL_PREFIX.
> This patch sets it to ".".
>
> Tested on cross to arm-wince-pe, arm-pe, arm-epoc-pe and arm-none-eabi.
>
> Please review and commit.
>
> Cheers,
> Pedro Alves
>
> ---
>
> bfd/ChangeLog:
>
> 2006-10-21  Pedro Alves  <pedro_alves@portugalmail.pt>
>
>        * pe-arm-wince.c (LOCAL_LABEL_PREFIX): Define as ".".
>     * pei-arm-wince.c (LOCAL_LABEL_PREFIX): Likewise.
>     * coff-arm.c (LOCAL_LABEL_PREFIX): Only define if not defined before.
>
>
> gas/testsuite/ChangeLog:
>
> 2006-10-21  Pedro Alves  <pedro_alves@portugalmail.pt>
>
>        * gas/arm/undefined.d: Run test on Windows CE.
>        * gas/arm/undefined_coff.d: Don't run test on Windows CE.
And now the patch without missing any file. <g>

Cheers,
Pedro Alves

Index: bfd/pe-arm-wince.c
===================================================================
RCS file: /cvs/src/src/bfd/pe-arm-wince.c,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 pe-arm-wince.c
--- bfd/pe-arm-wince.c	21 Aug 2006 08:12:45 -0000	1.1
+++ bfd/pe-arm-wince.c	21 Oct 2006 02:27:56 -0000
@@ -32,4 +32,6 @@ Foundation, Inc., 51 Franklin Street - F
 #define bfd_arm_process_before_allocation \
   bfd_arm_wince_pe_process_before_allocation
 
+#define LOCAL_LABEL_PREFIX "."
+
 #include "pe-arm.c"
Index: bfd/pei-arm-wince.c
===================================================================
RCS file: /cvs/src/src/bfd/pei-arm-wince.c,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 pei-arm-wince.c
--- bfd/pei-arm-wince.c	21 Aug 2006 08:12:45 -0000	1.1
+++ bfd/pei-arm-wince.c	21 Oct 2006 02:27:56 -0000
@@ -25,4 +25,6 @@ Foundation, Inc., 51 Franklin Street - F
 #define TARGET_BIG_SYM       arm_wince_pei_big_vec
 #define TARGET_BIG_NAME      "pei-arm-wince-big"
 
+#define LOCAL_LABEL_PREFIX "."
+
 #include "pei-arm.c"
Index: bfd/coff-arm.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-arm.c,v
retrieving revision 1.68
diff -u -p -u -p -r1.68 coff-arm.c
--- bfd/coff-arm.c	21 Aug 2006 08:12:44 -0000	1.68
+++ bfd/coff-arm.c	21 Oct 2006 02:27:58 -0000
@@ -2424,7 +2424,9 @@ Warning: Clearing the interworking flag 
 
 /* Note:  the definitions here of LOCAL_LABEL_PREFIX and USER_LABEL_PREIFX
    *must* match the definitions in gcc/config/arm/{coff|semi|aout}.h.  */
+#ifndef LOCAL_LABEL_PREFIX
 #define LOCAL_LABEL_PREFIX ""
+#endif
 #ifndef USER_LABEL_PREFIX
 #define USER_LABEL_PREFIX "_"
 #endif
Index: gas/testsuite/gas/arm/undefined.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arm/undefined.d,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 undefined.d
--- gas/testsuite/gas/arm/undefined.d	4 Jul 2005 14:57:45 -0000	1.1
+++ gas/testsuite/gas/arm/undefined.d	21 Oct 2006 02:27:58 -0000
@@ -1,4 +1,5 @@
 #name: Undefined local label error
-# COFF and aout based ports use a different naming convention for local labels.
-#skip: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd *-*-riscix*
+# COFF and aout based ports, except Windows CE, 
+# use a different naming convention for local labels.
+#skip: *-*-*coff *-unknown-pe *-epoc-pe *-*-*aout* *-*-netbsd *-*-riscix*
 #error-output: undefined.l
Index: gas/testsuite/gas/arm/undefined_coff.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arm/undefined_coff.d,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 undefined_coff.d
--- gas/testsuite/gas/arm/undefined_coff.d	4 Jul 2005 14:57:45 -0000	1.1
+++ gas/testsuite/gas/arm/undefined_coff.d	21 Oct 2006 02:27:58 -0000
@@ -1,4 +1,5 @@
 #name: Undefined local label error
-# COFF and aout based ports use a different naming convention for local labels.
-#not-skip: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd *-*-riscix*
+# COFF and aout based ports, except Windows CE, 
+# use a different naming convention for local labels.
+#not-skip: *-*-*coff *-unknown-pe *-epoc-pe *-*-*aout* *-*-netbsd *-*-riscix*
 #error-output: undefined_coff.l