This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: remove impossible case from gas/expr.c:expr


Ben Elliston <bje@au1.ibm.com> writes:

> A static analysis tool that I ran over gas picked this up.  It is
> impossible for op_left to be O_add in the switch (op_left), as it is
> within the body of this if:

That's a nice bit of analysis.

> 2006-10-24  Ben Elliston  <bje@au.ibm.com>
> 
>         * expr.c (expr): Don't handle impossible case O_add when switching
>         on op_left.

Please leave a comment behind, so that a couple of years from now
somebody comparing the list in expr.h with the list in expr.c won't
get confused.

OK with that change.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]