This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Support .cfi_personality and .cfi_lsda directives
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: binutils at sources dot redhat dot com, Ulrich Drepper <drepper at redhat dot com>
- Date: Thu, 2 Nov 2006 17:28:13 +0100
- Subject: Re: [PATCH] Support .cfi_personality and .cfi_lsda directives
- References: <20061101165548.GX5868@sunsite.mff.cuni.cz> <20061102153007.GA3241@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Nov 02, 2006 at 07:30:07AM -0800, Richard Henderson wrote:
> On Wed, Nov 01, 2006 at 05:55:49PM +0100, Jakub Jelinek wrote:
> > * dw2gencfi.c (struct fde_entry): Add per_encoding, lsda_encoding,
> > personality and lsda.
> > (struct cie_entry): Add per_encoding, lsda_encoding and personality.
> > (alloc_fde_entry): Initialize per_encoding and lsda_encoding.
> > (cfi_pseudo_table): Handle .cfi_personality and .cfi_lsda.
> > (dot_cfi_personality, dot_cfi_lsda, encoding_size): New functions.
> > (output_cie): Output personality including its encoding and LSDA encoding.
> > (output_fde): Output LSDA.
> > (select_cie_for_fde): Don't share CIE if personality, its encoding or
> > LSDA encoding are different. Copy the 3 fields from fde_entry to
> > cie_entry.
> > * doc/as.texinfo (.cfi_personality, .cfi_lsda): Document.
>
> Looks good to me.
>
> Ok.
Thanks, though this patch relies on the earlier:
http://sources.redhat.com/ml/binutils/2006-10/msg00378.html
patch. Is that patch ok too (after fixing up the testcase comment as
requested by Andreas)?
Jakub