This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: New keywords (string32) for GNU as ?


Some lines in the patch got wrapped.
Full patch is available here: 
http://gsyprf11.external.hp.com/~deller/gas.patch


Helge Deller wrote:

> Hi Dave,
> 
> Dave Korn wrote:
>> On 19 November 2006 14:23, Helge Deller wrote:
>>> Would this kind of new keyword "in principle" be acceptable for GNU
>>> as/binutils ?
>> ....
>>   That said, I think your patch is well motivated and a reasonable
>>   solution to the problem.  I haven't tested it yet but it looks sane.
> 
> Thanks a lot for your feedback.
> 
> Below is an updated patch against CVS HEAD, which should include all your
> proposed changes, which include:
> - added .string64 as well (beside .string8, .string16, .string32)
> - cleaned up the coding style
> - fixed the comments
> - abort on coding error (if wrong bitsize was provided)
> - fixed up all callers of the stringer() function to include the bit size
> - added Changelog entries
> - added a testcase (strings.s, strings.d)
> 
> Additionally, I did tested, compiled and ran a "make check" sucessfully on
> Linux/i686/little-endian _and_ Linux/hppa/big-endian.
> 
> Could you please take a look at it again ?
> 
> As a side-note: If this patch would be ok, will someone (who?) take it up
> and commit, or should I maybe ask for a cvs-commit rights and commit
> myself ?
> 
> Helge
> 

<<< patch deleted >>>
available here: http://gsyprf11.external.hp.com/~deller/gas.patch



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]