This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86-64: fix Intel mode disassembly of cbw/cwd extensions
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <jbeulich at novell dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 1 Dec 2006 06:39:13 -0800
- Subject: Re: [PATCH] x86-64: fix Intel mode disassembly of cbw/cwd extensions
- References: <45702D70.76E4.0078.0@novell.com>
On Fri, Dec 01, 2006 at 12:26:08PM +0000, Jan Beulich wrote:
> cbw/cwd and derivates were not correctly disassembled in Intel mode.
>
> Built and tested on i686-pc-linux-gnu, x86_64-unknown-linux-gnu, and a few
> cross x86 targets.
>
> opcodes/
> 2006-11-30 Jan Beulich <jbeulich@novell.com>
>
> * i386-dis.c (dis386): Use 'R' and 'O' for cbw/cwd unconditionally.
> (putop): For 'O' suffix, print 'q' in Intel mode, and mark data prefix
> used. For 'R' and 'W' suffix, simplify and fix Intel mode.
>
> gas/testsuite/
> 2006-11-30 Jan Beulich <jbeulich@novell.com>
>
> * gas/i386/intel.s: Use Intel syntax in Intel syntax test.
> * gas/i386/x86-64-cbw.[sd]: New.
> * gas/i386/x86-64-cbw-intel.d: New.
> * gas/i386/i386.exp: Run new tests.
>
OK. Thanks.
H.J.