This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Re: Ld regressions on Linux/x86-64


H. J. Lu wrote:
On Mon, Feb 05, 2007 at 12:51:06PM -0800, H. J. Lu wrote:
Hi Dave,

Your checkins caused ld regressions on Linux/x86-64:

FAIL: visibility (hidden_normal) (PIC main)
FAIL: shared (PIC main)

Have you seen them?

I opened a bug report:


http://sources.redhat.com/bugzilla/show_bug.cgi?id=3972

I found the patch which corrects this problem. It was on an internal branch here at Red Hat and did not make it to the head of our repository from which I created my submission.

OK to commit?

BTW, I have never used the bugzilla system. What is the proper procedure after this patch has been approved and committed?

Dave
2007-02-05  Dave Brolley  <brolley@redhat.com>

	* Merge this change. The code is now in elflink.c.
	2003-10-17  Stan Cox  <scox@redhat.com>

	* elflink.h (elf_link_input_bfd): Always setup finfo->internal_syms.

Index: bfd/elflink.c
===================================================================
RCS file: /cvs/src/src/bfd/elflink.c,v
retrieving revision 1.246
diff -c -p -r1.246 elflink.c
*** bfd/elflink.c	5 Feb 2007 19:50:12 -0000	1.246
--- bfd/elflink.c	5 Feb 2007 22:58:55 -0000
*************** elf_link_input_bfd (struct elf_final_lin
*** 8082,8087 ****
--- 8082,8096 ----
        if (isymbuf == NULL)
  	return FALSE;
      }
+   /* evaluate_complex_relocation_symbols looks for symbols in
+      finfo->internal_syms.  */
+   else if (isymbuf != NULL && locsymcount != 0)
+     {
+       bfd_elf_get_elf_syms (input_bfd, symtab_hdr, locsymcount, 0,
+ 			    finfo->internal_syms,
+ 			    finfo->external_syms,
+ 			    finfo->locsym_shndx);
+     }
  
    /* Find local symbol sections and adjust values of symbols in
       SEC_MERGE sections.  Write out those local symbols we know are

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]