This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Configure options --with-bugurl, --with-pkgversion
On Fri, 16 Feb 2007, Alexandre Oliva wrote:
> On Feb 15, 2007, "Joseph S. Myers" <joseph@codesourcery.com> wrote:
>
> > Index: configure.ac
> > + ac_arg="`echo "'$ac_arg'" | sed "s/^'\([[-a-zA-Z0-9]]*=\)/\\1'/"`" ;;
>
> You don't want this kind of nesting of quotes, I think. In fact, you
> don't really need the outer-level double quotes, so just lose them and
> be safer.
>
> You probably want to quote single quotes the way autoconf does, before
> making the transformation above:
>
> ac_arg=`echo "$ac_arg" | sed "s/'/'\\\\\\\\''/g"`
I'll make these changes.
Note that TOPLEVEL_CONFIGURE_ARGUMENTS is only actually used by the gcc
subdirectory to include configure arguments in gcc -v, so the exact
quoting and formatting doesn't really matter much; it just ends up
producing human-readable text. This also means that the remainder of the
changes can be reviewed independently of the toplevel changes.
--
Joseph S. Myers
joseph@codesourcery.com