This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] mips: Print extra elf header flags.
On Sun, 18 Feb 2007, Carlos O'Donell wrote:
> On Fri, Feb 16, 2007 at 06:36:32PM -0500, Hans-Peter Nilsson wrote:
> > On Fri, 16 Feb 2007, Carlos O'Donell wrote:
> > > > On Fri, 16 Feb 2007, Carlos O'Donell wrote:
> > > > > + if (elf_elfheader (abfd)->e_flags & EF_MIPS_NOREORDER)
> > > > > + fprintf (file, _(" [.noreorder]"));
> >
> > > Is it a bad thing to mark all strings with _()? It's certainly an easier
> > > rule than "Use your discretion" :-)
> >
> > The rule of thumb is "does it make sense to have this text
> > output in another human language". E.g. "[ej omstuvad]" for the
> > above in Swedish (not an official translation).
>
> You avoided the question.
No I didn't; it seemed you didn't understand my reply so I
offered a longer explanation, which implied "bad: yes". If you
don't know it at this time, I suggest you take a brief look into
what actually happens with _() and the other i18n mechanisms.
(It's one of those "oh, icky issue, but I guess that's the best
way to do it without obfuscating the code too much" moments.)
> Is it a bad thing to mark all strings with
> _()?
Yes. You must understand what it means.
> Personally I would rather have all strings marked for
> translation.
Again, I suggest not, because sometimes there is the possibility
that the translator *will* translate something that *shouldn't*
be translated, e.g. "load" as a mnemonic and in the example
above, I think "noreorder" shouldn't be translated. (Not that
I'm sure it's proper English in the first place.)
brgds, H-P