This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gas/3918: make check RUNTESTFLAGS=i386.exp doesn't work
- From: Ben Elliston <bje at au1 dot ibm dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 06 Mar 2007 11:35:38 +1100
- Subject: Re: PATCH: PR gas/3918: make check RUNTESTFLAGS=i386.exp doesn't work
- References: <20070305210058.GA16248@lucon.org>
On Mon, 2007-03-05 at 13:00 -0800, H. J. Lu wrote:
> The problem is gas_finish. runtest.exp will call ${tool}_finish if it
> exists. But gas_finish isn't intended to be called by runtest.exp
> and should only be used with gas_start. When
>
> # make check RUNTESTFLAGS=i386.exp
>
> is used, gas_finish is called without gas_start and closes the wrong
> fd. We can rename gas_finish. But it is used in 250 places. This patch
> adds gas_started to make sure that it will be used when gas_start.
This patch is okay, but please add a comment above "set gas_started 1"
to explain why this variable is needed. Approved with this change.
Ben