This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[rfa] Do not expect frame base for inlined functions


I'm pretty sure this is correct.  Inlined subroutine DIEs should
generally not have a DW_AT_frame_base (the inlined instance does not
have a frame).  But it's fine for them to have variables which use
DW_OP_fbreg, and they'll use the enclosing DW_TAG_subprogram's frame
base.  OK to commit?

(Tested x86_64-linux, no regressions)

-- 
Daniel Jacobowitz
CodeSourcery

2007-03-06  Daniel Jacobowitz  <dan@codesourcery.com>

	* dwarf.c (process_debug_info): Do not require DW_AT_frame_base for
	DW_TAG_inlined_subroutine.

Index: dwarf.c
===================================================================
RCS file: /cvs/src/src/binutils/dwarf.c,v
retrieving revision 1.11
diff -u -p -r1.11 dwarf.c
--- dwarf.c	6 Feb 2007 16:47:47 -0000	1.11
+++ dwarf.c	6 Mar 2007 14:02:56 -0000
@@ -1733,7 +1733,6 @@ process_debug_info (struct dwarf_section
 	      need_base_address = 1;
 	      break;
 	    case DW_TAG_entry_point:
-	    case DW_TAG_inlined_subroutine:
 	    case DW_TAG_subprogram:
 	      need_base_address = 0;
 	      /* Assuming that there is no DW_AT_frame_base.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]