This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: windres


On Fri, Apr 13, 2007 at 04:19:25PM +0200, Kai Tietz wrote:
> "H. J. Lu" <hjl@lucon.org> wrote on 12.04.2007 18:56:45:
> 
> > On Thu, Apr 12, 2007 at 06:23:21PM +0200, Kai Tietz wrote:
> > > "H. J. Lu" <hjl@lucon.org> wrote on 12.04.2007 17:55:25:
> > > 
> > > > Can you try to use existing data type I/O routines in bfd?
> > > 
> > > You mean the endian swapping ?
> > > 
> > 
> > Yes. Also you should use
> > 
> > unsigned char characteristics [4];
> > 
> > instead of
> > 
> > unsigned long characteristics;
> > 
> > or
> > 
> > unsigned int characteristics;
> 
> Nightmares, ... 8| I begun to modify structure using character arrays ... 
> I come to the point, that this means for big parts of windres better a 
> complete rewrite. Structures with internal/external scope and data 
> modifications are really wired.
> May we should first use my last patch, so that the problem is solved, and 
> then I will begin to reorganize the windres tool to be host idependent. By 
> this I can add some missing resource types to it.
> 
> What do you think about my suggestion to continue ?
> 

That is fine with me. If you do this, you don't need to handle
endian and just replace long with int since you will rewrite it
later anyway.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]