This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] gprof: accept nested subprograms


Hi Tristan,

Updated version (thank you for pointing out typos)

gprof/ChangeLog:
2007-07-04  Tristan Gingold  <gingold@adacore.com>

* corefile.c (core_sym_class): Do not discard nested subprograms.

There were two more minor problems with this patch:


  * You used <ctype.h> but it is better to use "safe-ctype.h" and
    replace the call to isdigit with a call to ISDIGIT.

  * You forgot to update Makefile.am to add a dependency for corefile.o
    upon ctype.h (or safe-ctype.h).

I have taken care of these two problems and applied your patch along with this ChangeLog entry.

Cheers
  Nick

gprof/ChangeLog
2007-07-05  Tristan Gingold  <gingold@adacore.com>

	* corefile.c (core_sym_class): Do not discard nested subprograms.
	* Makefile.am (corefile.o): Add dependency upon safe-ctype.h.
	* Makefile.in: Regenerate.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]