This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: removing reliance on NBPG/UPAGES in bfd/trad-core.c

From: Mike Frysinger <vapier at gentoo dot org>
To: Nick Clifton <nickc at redhat dot com>
Cc: binutils at sourceware dot org
Date: Sun, 15 Jul 2007 02:32:59 -0400
Subject: Re: removing reliance on NBPG/UPAGES in bfd/trad-core.c
References: <200702132147.28532.vapier@gentoo.org> <200703161749.54665.vapier@gentoo.org> <45FFD17B.3040602@redhat.com>

On Tuesday 20 March 2007, Nick Clifton wrote:
> Hi Mike,
>
> >>> #ifndef NBPG
> >>> # define NBPG getpagesize()
> >>> #endif
> >>
> >> I think that this would be safer.
> >
> > attached then, OK to commit ?
>
> Yes, but in the future please include a ChangeLog entry

it was in the patch ... should i post it inline in the e-mail ?

> and also mention 
> how you tested the patch to make sure that it does not break anything.

tested on alpha/Linux and x86_64/Linux with --enable-targets=all with no 
regressions ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: removing reliance on NBPG/UPAGES in bfd/trad-core.c
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]