This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Fix ARM's .unreq pseudo op
- From: "H.J. Lu" <hjl at lucon dot org>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Sun, 15 Jul 2007 06:39:48 -0700
- Subject: Re: PATCH: Fix ARM's .unreq pseudo op
- References: <m3hco7ot6z.fsf@redhat.com>
On Sat, Jul 14, 2007 at 05:17:56PM +0100, Nick Clifton wrote:
> Hi Guys,
>
> A bug was recently reported against the ARM assembler whereby
> attempting to re-create a previously deleted register alias would
> fail because the assembler had silently created an upper case and
> lower case version of the alias:
>
> % cat foo.s
> foo .req r0
> .unreq foo
> foo .req r1
>
> % as foo.s
> Warning: ignoring redefinition of register alias 'FOO'
>
> I am checking in the attached patch and testcase to fix this problem
> and make sure that it does not resurface.
>
> Cheers
> Nick
>
> gas/ChangeLog
> 2007-07-14 Nick Clifton <nickc@redhat.com>
>
> * config/tc-arm.c (create_register_alias): Return a boolean rather
> than an integer.
> Check the return value of insert_reg_alias and do not continue to
> create aliases once an insertion has failed.
> (s_unreq): Delete the all-upper-case and all-lower-case
> alternatives as well.
>
Does it fix
http://sourceware.org/bugzilla/show_bug.cgi?id=4657
H.J.