This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: better error messages
- From: Andreas Schwab <schwab at suse dot de>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: binutils <binutils at sources dot redhat dot com>
- Date: Fri, 27 Jul 2007 18:03:12 +0200
- Subject: Re: better error messages
- References: <46AA13C0.9010505@codesourcery.com>
Nathan Sidwell <nathan@codesourcery.com> writes:
> Index: bucomm.c
> ===================================================================
> RCS file: /cvs/src/src/binutils/bucomm.c,v
> retrieving revision 1.31
> diff -c -3 -p -r1.31 bucomm.c
> *** bucomm.c 5 Jul 2007 16:54:45 -0000 1.31
> --- bucomm.c 27 Jul 2007 15:40:25 -0000
> *************** bfd_nonfatal (const char *string)
> *** 61,66 ****
> --- 61,99 ----
> }
>
> void
> + bfd_nonfatal_message (const char *filename,
> + const bfd *bfd, const asection *section,
> + const char *format, ...)
> + {
> + const char *errmsg = bfd_errmsg (bfd_get_error ());
> + const char *section_name = NULL;
> + va_list args;
> +
Please add a comment before the function describing its purpose and how
the arguments are used.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."