This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix run_list_test for MIPS gas

From: David Daney <ddaney at avtrex dot com>
To: Thiemo Seufer <ths at networkno dot de>
Cc: binutils at sourceware dot org, richard at codesourcery dot com
Date: Mon, 30 Jul 2007 11:13:50 -0700
Subject: Re: Fix run_list_test for MIPS gas
References: <87ejiz5orr.fsf@firetop.home> <20070730180352.GK26960@networkno.de>

Thiemo Seufer wrote:

Richard Sandiford wrote:
[snip]

There are two problems: mips.exp uses run_list_test with no options
argument, and cr16.exp overrides the gas-defs.exp definition before
mips.exp runs.

I think the best fix for the first problem is to make the options
optional.  For the second, it's trivially safe to delete the cr16.exp
definition because cr16.exp contains no list tests.

Tested on mipsisa64-elf. OK to install?

Richard


gas/testsuite/
	* lib/gas-defs.exp (run_list_test): Make the options optional.
	* gas/cr16/cr16.exp (run_list_test): Delete.


Could somebody please review this patch? It looks good to me, but I
can't approve it.

http://sourceware.org/ml/binutils/2007-07/msg00353.html

Thiemo

References:
- Fix run_list_test for MIPS gas
  - From: Richard Sandiford
- Re: Fix run_list_test for MIPS gas
  - From: Thiemo Seufer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]