This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH,ppc] fix segfaults when relocating against undefined symbols
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org
- Date: Wed, 10 Oct 2007 09:52:13 +0930
- Subject: Re: [PATCH,ppc] fix segfaults when relocating against undefined symbols
- References: <20071009181542.GA31776@codesourcery.com>
On Tue, Oct 09, 2007 at 11:15:42AM -0700, Nathan Froyd wrote:
> case R_PPC_TOC16: /* phony GOT16 relocations */
> - BFD_ASSERT (sec != NULL);
> + if (sec == NULL)
> + continue;
I think you should break rather than continue, so that you get the
unresolvable relocation error. OK with that difference in all the
cases you change.
--
Alan Modra
Australia Development Lab, IBM