This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,ppc] fix segfaults when relocating against undefined symbols


On Tue, Oct 09, 2007 at 11:15:42AM -0700, Nathan Froyd wrote:
>  	case R_PPC_TOC16:			/* phony GOT16 relocations */
> -	  BFD_ASSERT (sec != NULL);
> +	  if (sec == NULL)
> +	    continue;

I think you should break rather than continue, so that you get the
unresolvable relocation error.  OK with that difference in all the
cases you change.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]